feat: export ipfs_p2p metrics like Kubo does #32
Conversation
| if c.Node.host == nil { | ||
| return vals | ||
| } | ||
| for _, peerID := range c.Node.host.Network().Peers() { |
There was a problem hiding this comment.
Do we only want the data transfer peers or, also the DHT peers. Since they are (optionally) on different hosts we may need to check there as well. If both do we want to deduplicate by peerID?
There was a problem hiding this comment.
@aschmahmann good point.
Now, I would like to compare perf between using a single host and using two hosts. I'm not sure it makes a difference tbh. Would you be ok with using a single host for everything if thunderdome shows it is not worse?
There was a problem hiding this comment.
I'm fine with one host if behavior looks the same (i.e. if it's less complexity for a similar result).
IIUC this metric just tracks the peers we're connected to, not other things like bandwidth. Not sure how those are currently set up given two hosts.
hacdias
changed the title
Copy-pasted some code from Kubo
hacdias
force-pushed
the
ipfs-p2p-metrics
branch
from
70df2cd
to
77cf7fa
Compare
Copy-pasted some code from Kubo.